From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXAks-0000g9-OX for qemu-devel@nongnu.org; Fri, 18 Oct 2013 10:10:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VXAkk-0007r1-70 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 10:10:18 -0400 Received: from mail-ea0-x22f.google.com ([2a00:1450:4013:c01::22f]:49226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXAkj-0007ql-W3 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 10:10:10 -0400 Received: by mail-ea0-f175.google.com with SMTP id m14so1994375eaj.20 for ; Fri, 18 Oct 2013 07:10:09 -0700 (PDT) Date: Fri, 18 Oct 2013 16:10:06 +0200 From: Stefan Hajnoczi Message-ID: <20131018141006.GC22532@stefanha-thinkpad.redhat.com> References: <1382078393-11195-1-git-send-email-mohamad.gebai@polymtl.ca> <1382078393-11195-4-git-send-email-mohamad.gebai@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382078393-11195-4-git-send-email-mohamad.gebai@polymtl.ca> Subject: Re: [Qemu-devel] [PATCH v4 3/5] Adapt Makefiles to the new LTTng ust interface. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mohamad Gebai Cc: Mohamad Gebai , alex.bennee@linaro.org, qemu-devel@nongnu.org On Fri, Oct 18, 2013 at 02:39:51AM -0400, Mohamad Gebai wrote: > ###################################################################### > +# Auto-generated event descriptions for LTTng ust code > + > +ifeq ($(TRACE_BACKEND),ust) > +$(obj)/generated-ust-provider.h: $(obj)/generated-ust-provider.h-timestamp > +$(obj)/generated-ust-provider.h-timestamp: $(SRC_PATH)/trace-events > + $(call quiet-command,$(TRACETOOL) \ > + --format=ust-events-h \ > + --backend=events \ > + < $< > $@," GEN $(patsubst %-timestamp,%,$@)") > + @cmp -s $@ $(patsubst %-timestamp,%,$@) || cp $@ $(patsubst %-timestamp,%,$@) > + > +$(obj)/generated-ust.c: $(obj)/generated-ust.c-timestamp $(BUILD_DIR)/config-host.mak > +$(obj)/generated-ust.c-timestamp: $(SRC_PATH)/trace-events > + $(call quiet-command,$(TRACETOOL) \ > + --format=ust-events-c \ > + --backend=events \ > + < $< > $@," GEN $(patsubst %-timestamp,%,$@)") > + @cmp -s $@ $(patsubst %-timestamp,%,$@) || cp $@ $(patsubst %-timestamp,%,$@) > + > +ust_provider=$(obj)/generated-ust-provider.h > +ust=$(obj)/generated-ust.c I think you can avoid the variables by defining single dependencies upfront: $(obj)/generated-events.h: $(obj)/generated-ust-provider.h $(obj)/generated-events.c: $(obj)/generated-ust.c