From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dmitry Krivenok <krivenok.dmitry@gmail.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] net: disallow to specify multicast MAC address
Date: Fri, 18 Oct 2013 18:40:25 +0200 [thread overview]
Message-ID: <20131018164025.GA29916@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CAJN_NGZ_CosR42CkUiPMd56DW2x1P6gCUAroyib62Howy1OuFA@mail.gmail.com>
On Thu, Oct 17, 2013 at 07:06:28PM +0400, Dmitry Krivenok wrote:
> +bool net_macaddr_is_multicast(uint8_t *macaddr)
> +{
> + return (macaddr[0] % 2) ? true : false;
> +}
Please use is_multicast_ether_addr() instead. Thanks Amos for pointing
out this function is duplicated.
I have dropped this patch and will merge the next revision instead.
next prev parent reply other threads:[~2013-10-18 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 15:06 [Qemu-devel] [PATCH] net: disallow to specify multicast MAC address Dmitry Krivenok
2013-10-17 15:19 ` Eric Blake
2013-10-17 18:44 ` Dmitry Krivenok
2013-10-18 11:25 ` Stefan Hajnoczi
2013-10-18 16:40 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-17 11:07 Dmitry Krivenok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018164025.GA29916@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aliguori@amazon.com \
--cc=krivenok.dmitry@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).