From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VXD6K-0006oK-SV
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 12:40:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VXD6C-0006v7-FS
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 12:40:36 -0400
Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:40891)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VXD6C-0006ut-9M
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 12:40:28 -0400
Received: by mail-ee0-f52.google.com with SMTP id d51so291113eek.25
	for <qemu-devel@nongnu.org>; Fri, 18 Oct 2013 09:40:27 -0700 (PDT)
Date: Fri, 18 Oct 2013 18:40:25 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131018164025.GA29916@stefanha-thinkpad.redhat.com>
References: <CAJN_NGZ_CosR42CkUiPMd56DW2x1P6gCUAroyib62Howy1OuFA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJN_NGZ_CosR42CkUiPMd56DW2x1P6gCUAroyib62Howy1OuFA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] net: disallow to specify multicast MAC
 address
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Krivenok <krivenok.dmitry@gmail.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Thu, Oct 17, 2013 at 07:06:28PM +0400, Dmitry Krivenok wrote:
> +bool net_macaddr_is_multicast(uint8_t *macaddr)
> +{
> +    return (macaddr[0] % 2) ? true : false;
> +}

Please use is_multicast_ether_addr() instead.  Thanks Amos for pointing
out this function is duplicated.

I have dropped this patch and will merge the next revision instead.