From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34054)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <m@bues.ch>)
	id 1VYEAB-0007bz-Ez
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 08:00:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <m@bues.ch>) id 1VYEA6-0003Ei-Iq
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 08:00:47 -0400
Received: from bues.ch ([80.190.117.144]:38941)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <m@bues.ch>)
	id 1VYEA6-0003DX-By
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 08:00:42 -0400
Received: by bues.ch with esmtpsa (Exim 4.80) (envelope-from <m@bues.ch>)
	id 1VYE9w-0000RO-9E
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 14:00:32 +0200
Date: Mon, 21 Oct 2013 13:50:02 +0200
From: Michael =?UTF-8?B?QsO8c2No?= <m@bues.ch>
Message-ID: <20131021135002.45f526f2@wiggum>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=PGP-SHA1;
	boundary="Sig_/tBR8rW=aUNcXqQllW9u=1i.";
	protocol="application/pgp-signature"
Subject: [Qemu-devel] Fix SMB security configuration on newer samba versions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

--Sig_/tBR8rW=aUNcXqQllW9u=1i.
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

The following changes fix the samba security configuration on
newer samba versions.

samba version 4.0.10-Debian throws this warning:

>   WARNING: Ignoring invalid value 'share' for parameter 'security'

Which makes it fall back to security=3Duser without guest login.

Fix this by selecting 'user' explicitly and mapping unknown users to guest =
logins.

Signed-off-by: Michael Buesch <m@bues.ch>

---
Index: qemu-1.6.1/net/slirp.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- qemu-1.6.1.orig/net/slirp.c	2013-10-09 21:20:32.000000000 +0200
+++ qemu-1.6.1/net/slirp.c	2013-10-21 13:49:39.918960448 +0200
@@ -529,7 +529,8 @@
             "state directory=3D%s\n"
             "log file=3D%s/log.smbd\n"
             "smb passwd file=3D%s/smbpasswd\n"
-            "security =3D share\n"
+            "security =3D user\n"
+            "map to guest =3D Bad User\n"
             "[qemu]\n"
             "path=3D%s\n"
             "read only=3Dno\n"

--Sig_/tBR8rW=aUNcXqQllW9u=1i.
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJSZRTqAAoJEPUyvh2QjYsOJ1cP/iEeYFfCo0Cdf0EyaqyrvGXW
7BV2+dAQXFBuyv9AulZsrf/19Jdd5XPRFzZb5OgGMIinq34zEhuQRmZzAz9Vf4QM
0lceB4sAJYIgLUWQlCpp0Wvbozx18ofPM+J5WQzFWnH2AveQC4CMIXG+TlXGTYBP
U09UJ3ZV6DbJ5EpYOr1g1XCg2dzZ+A3Jb6WCT8km1JSy3pdzU+P4TWtNFtpzgA9o
z1YMJeNLmGhfPcEh6Xv+5R4Z2g6Qm0Uz39kWk5NcHQYlOxIspAnoS8D/pa6i2oXZ
A3B/xREQT3em5OF7WDWMw6umDnvRBItoUzs4aYnvQXeLft2ll/68nCXjOFBPHZbr
pq3n28lEjOJUXZghCLODck6B1ea3eIq73Li6T0I125sXCMYaoquJ7GX9jxDyCV1/
zCVXjP4u3cDER+b6f7bPWPgmuhWthXD8J7HC4jpoUCB2M/Jxrar0qC9cOTZFhqTZ
RKDHDt7ZR4BLDmNWUr7xqS13xnJ4Mc8cp9CJeM3AQlFaNBQ2fjfl5jBmrIFdKEmV
8Fq0TTs4+u1JUul7k1XOIbsR8TNW4eEBae4qxIuDqxe7CFRWSaq1z0zYfKpGHWx+
g1x6h7kCPyz+yWYAPzpFPJhF/iRznZimRV64mcLMmbOwYJxk3zDQqADrVs4pxkYz
HnggEaO83sd6805B8GNJ
=YGkg
-----END PGP SIGNATURE-----

--Sig_/tBR8rW=aUNcXqQllW9u=1i.--