From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Unset zero_beyond_eof in save_vmstate
Date: Thu, 24 Oct 2013 11:52:30 +0200 [thread overview]
Message-ID: <20131024095230.GC7385@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <52659071.4070003@redhat.com>
Am 21.10.2013 um 22:37 hat Eric Blake geschrieben:
> On 10/20/2013 08:52 PM, Max Reitz wrote:
> > Saving the VM state is done using bdrv_pwrite. This function may perform
> > a read-modify-write, which in this case results in data being read from
> > beyond the end of the virtual disk. Since we are actually trying to
> > access an area which is not a part of the virtual disk, zero_beyond_eof
> > has to be set to false before performing the partial write, otherwise
> > the VM state may become corrupted.
> >
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > ---
> > Follow-up to (depends on):
> > - qcow2: Restore total_sectors value in save_vmstate
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2013-10-24 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 19:52 [Qemu-devel] [PATCH] qcow2: Unset zero_beyond_eof in save_vmstate Max Reitz
2013-10-21 20:37 ` Eric Blake
2013-10-23 17:07 ` Max Reitz
2013-10-23 18:27 ` Max Reitz
2013-10-24 9:52 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024095230.GC7385@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).