From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VZHaq-0001uK-T7
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:52:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VZHaj-00088t-Sc
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:52:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VZHaj-00088i-KV
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:52:33 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9O9qWqF018851
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 24 Oct 2013 05:52:32 -0400
Date: Thu, 24 Oct 2013 11:52:30 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131024095230.GC7385@dhcp-200-207.str.redhat.com>
References: <1382298755-21383-1-git-send-email-mreitz@redhat.com>
	<52659071.4070003@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52659071.4070003@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Unset zero_beyond_eof in
	save_vmstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

Am 21.10.2013 um 22:37 hat Eric Blake geschrieben:
> On 10/20/2013 08:52 PM, Max Reitz wrote:
> > Saving the VM state is done using bdrv_pwrite. This function may perform
> > a read-modify-write, which in this case results in data being read from
> > beyond the end of the virtual disk. Since we are actually trying to
> > access an area which is not a part of the virtual disk, zero_beyond_eof
> > has to be set to false before performing the partial write, otherwise
> > the VM state may become corrupted.
> > 
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > ---
> > Follow-up to (depends on):
> >  - qcow2: Restore total_sectors value in save_vmstate
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks, applied to the block branch.

Kevin