From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error
Date: Mon, 28 Oct 2013 17:37:53 +0100 [thread overview]
Message-ID: <20131028163753.GA3576@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1382795083-28591-1-git-send-email-mreitz@redhat.com>
Am 26.10.2013 um 15:44 hat Max Reitz geschrieben:
> bdrv_open_backing_file() tries to copy the backing file name using
> pstrcpy directly after calling bdrv_open() to open the backing file
> without checking whether that was actually successful. If it was not,
> ps->backing_hd->file will probably be NULL and qemu will crash.
>
> Fix this by moving pstrcpy after checking whether bdrv_open() succeeded.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied. A test case wouldn't hurt, though.
Kevin
prev parent reply other threads:[~2013-10-28 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 13:44 [Qemu-devel] [PATCH] block: Don't copy backing file name on error Max Reitz
2013-10-27 10:32 ` Amos Kong
2013-10-28 15:02 ` Benoît Canet
2013-10-28 16:37 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028163753.GA3576@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).