From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Thibaut LAURENT <thibaut.laurent@gmail.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file.
Date: Tue, 29 Oct 2013 12:56:28 +0100 [thread overview]
Message-ID: <20131029115628.GC4690@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <526BC420.80907@redhat.com>
Am 26.10.2013 um 15:31 hat Max Reitz geschrieben:
> Am 25.10.2013 02:15, schrieb Thibaut LAURENT:
> > Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c,
> > bdrv_open_common will throw an error when trying to open a file
> > read-only with the BDRV_O_COPY_ON_READ flag set.
> > Although BDRV_O_RDWR is unset for the backing files,
> > BDRV_O_COPY_ON_READ is still passed on if copy-on-read was requested
> > for the drive. Let's unset this flag too before opening the backing
> > file, or bdrv_open_common will fail.
> >
> > Signed-off-by: Thibaut LAURENT <thibaut.laurent@gmail.com>
> > ---
> > block.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch. (And thanks for CCing me, Max, I
would have missed the patch otherwise.)
Kevin
next prev parent reply other threads:[~2013-10-29 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 0:15 [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file Thibaut LAURENT
2013-10-26 13:31 ` Max Reitz
2013-10-29 11:56 ` Kevin Wolf [this message]
2013-10-28 15:08 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029115628.GC4690@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thibaut.laurent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).