From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAtv-0004em-PQ for qemu-devel@nongnu.org; Tue, 29 Oct 2013 11:08:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbAtq-0007NW-Ew for qemu-devel@nongnu.org; Tue, 29 Oct 2013 11:08:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAtq-0007NG-6E for qemu-devel@nongnu.org; Tue, 29 Oct 2013 11:08:06 -0400 Date: Tue, 29 Oct 2013 17:10:47 +0200 From: "Michael S. Tsirkin" Message-ID: <20131029151047.GA20242@redhat.com> References: <1383051455-28188-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383051455-28188-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2 v2] pc: inform SeaBIOS where 64-bit PCI hole begins List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, afaerber@suse.de On Tue, Oct 29, 2013 at 01:57:33PM +0100, Igor Mammedov wrote: > * simplify PCI address space mapping into system address space, > replacing code duplication in piix/q53 PCs with a helper function > > * add fw_cfg 'etc/pcimem64-minimum-address' to allow QEMU reserve > additional address space before 64-bit PCI hole. Which will be > need for reserving memory hotplug region in highmem. > SeaBIOS counterpart: http://patchwork.ozlabs.org/patch/283623/ I'd like to see if we can figure out the migration issue with memory layout. Because if we do, and get rid of the separate 64 bit region as a concept, exposing the start of this non-existent region in FW CFG will make very little sense IMHO. > v2: > * use negative priority to map PCI address space under RAM memory > regions which allows simplify code by removing pci_hole & > pci_hole64 memory region aliases > > Series depends on: > "memory: Change MemoryRegion priorities from unsigned to signed: > > Git tree for testing: > https://github.com/imammedo/qemu/commits/pcimem64-minimum-address-v2 > > Igor Mammedov (1): > pc: add 'etc/pcimem64-minimum-address' fw_cfg interface to SeaBIOS > > Michael S. Tsirkin (1): > pc: map PCI address space as catchall region for not mapped addresses > > hw/i386/pc.c | 28 ++++++++++++++++------------ > hw/i386/pc_piix.c | 2 -- > hw/pci-host/piix.c | 27 +++++---------------------- > hw/pci-host/q35.c | 28 ++++++---------------------- > include/hw/i386/pc.h | 15 +++------------ > include/hw/pci-host/q35.h | 2 -- > 6 files changed, 30 insertions(+), 72 deletions(-)