From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAw4-0005jF-E6 for qemu-devel@nongnu.org; Tue, 29 Oct 2013 11:10:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbAvy-00009W-G6 for qemu-devel@nongnu.org; Tue, 29 Oct 2013 11:10:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbAvy-00008q-6h for qemu-devel@nongnu.org; Tue, 29 Oct 2013 11:10:18 -0400 Date: Tue, 29 Oct 2013 17:12:59 +0200 From: "Michael S. Tsirkin" Message-ID: <20131029151259.GB20242@redhat.com> References: <1383057307-4814-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383057307-4814-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH for 1.7] pc: disable pci-info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ehabkost@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de On Tue, Oct 29, 2013 at 03:35:07PM +0100, Igor Mammedov wrote: > The BIOS that we ship in 1.7 does not use pci info > from host and so far isn't going to use it. > Taking in account problems it caused see 9604f70fdf and > to avoid future incompatibility issues, it's safest to > disable that interface by default for all machine types > including 1.7 as it was never exposed/used by guest. > And properly remove/cleanup it during 1.8 development cycle. > > Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin > --- > hw/i386/pc_piix.c | 3 ++- > hw/i386/pc_q35.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index c6042c7..4a4d969 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -58,7 +58,8 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > > static bool has_pvpanic; > -static bool has_pci_info = true; > +/* TODO: remove unused "etc/pci-info" */ > +static bool has_pci_info; > > /* PC hardware initialisation */ > static void pc_init1(QEMUMachineInitArgs *args, > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index ca84e1c..8e5c1ae 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -48,7 +48,8 @@ > #define MAX_SATA_PORTS 6 > > static bool has_pvpanic; > -static bool has_pci_info = true; > +/* TODO: remove unused "etc/pci-info" */ > +static bool has_pci_info; > > /* PC hardware initialisation */ > static void pc_q35_init(QEMUMachineInitArgs *args) > -- > 1.7.1