From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbDsZ-0002uu-CN for qemu-devel@nongnu.org; Tue, 29 Oct 2013 14:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbDsR-0005Qh-E9 for qemu-devel@nongnu.org; Tue, 29 Oct 2013 14:18:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbDsR-0005QE-67 for qemu-devel@nongnu.org; Tue, 29 Oct 2013 14:18:51 -0400 Date: Tue, 29 Oct 2013 19:18:45 +0100 From: Kevin Wolf Message-ID: <20131029181845.GA25726@dhcp-200-207.str.redhat.com> References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382321765-29052-4-git-send-email-xiawenc@linux.vnet.ibm.com> <5265917D.3000903@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <5265917D.3000903@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, Wenchao Xia --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 21.10.2013 um 22:41 hat Eric Blake geschrieben: > On 10/21/2013 03:16 AM, Wenchao Xia wrote: > > The define will be moved to qapi-schema.json later, so rename the > > prefix to match its naming style. >=20 > Wouldn't it be simpler to fix the code generator to special case QEvent > to turn into QEVENT, instead of having to go through this churn? But if > we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical: Or rather, instead of special casing QEvent, it shouldn't insert underscores if there is nothing between the two capital letters. I've had a similar case with AIO in the blockdev-add series; and while renaming it to Aio worked, this kind of thing doesn't seem to be a rare exception in practice, so it might be worth adjusting the generator. Kevin --envbJBWh7q8WU6mo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJSb/wFAAoJEH8JsnLIjy/WWboQAMHoaEHfMSrP7AWgsB3d00us AJC2YuYqvSVd6kPz9VkUeB5Nft+4QkRRQWNlXpWpW7l7+4wWX7sWP5n+8wQA0MQ8 uB6Z9RVlTpPBcTI8OvG01JFxGRv0lv+BS4ibxn3IG9eCB1KIaRbEeOySDvsyYsb3 eFZpKXbv31wd+kN4MGUteiL5WyQM7ITwqFXRUTYnNlurURNdkej0/xJlsAyTiEyN yM9ePm6FrY2nkp0XDy1MeLkFZM+pL9cvsRhGsA9qWWo0FhoKpnPg/rDWJh1pJ5Mq 6N08Wb+FpUnSN5x6bK0Lqw35z/e0+qTY5arSyRmJZ2kmJEvyIL5sfvIkxcw7d770 fInEA06Y5m88BRoDGPY+6yb1rAZtDaQDHOSSaqA+2j+lQuxJToW+bPeqWHXN6gfT /tNQfxb5YRrdgKu96MO7H6cjoJof5OYQYUpbqzOkyVo8fTJR6zNSduK8pwRM3JMY 3jsGnt17AKXnhf9qG1ZHDGDQHcweJQrNpko5rcibSkLN4oVZ+t457Hc4DCnavUiR YsoXlBa/maBh0htZDX2XeGqQakWNqYJKV5FmEvigFVmEtNGC4bDztHVHgvXGTYIL yBn4SeY6DsffmoRWBRvFeU2tAvEHaqOZma+N0XCSCPHlOt98GI4fUIIP179BWn37 /VlvjTzZKz0UbdCWNGwJ =B5l2 -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--