From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbE3q-0000oX-5R for qemu-devel@nongnu.org; Tue, 29 Oct 2013 14:30:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbE3j-0001D1-RU for qemu-devel@nongnu.org; Tue, 29 Oct 2013 14:30:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbE3j-0001Cv-K9 for qemu-devel@nongnu.org; Tue, 29 Oct 2013 14:30:31 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9TIUVJu030603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 29 Oct 2013 14:30:31 -0400 Date: Tue, 29 Oct 2013 19:30:25 +0100 From: Kevin Wolf Message-ID: <20131029183025.GB25726@dhcp-200-207.str.redhat.com> References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382978620-16641-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben: > Hi all, > > this is some cleanup to the IDE code that I started long ago > and picked up again on my flight back from KVM Forum... > > The patches clean up the callbacks to prepare for implementing request > retry for AHCI. After these patches, PIO retry should work for AHCI and > non-NCQ retry should be very close (you need an implementation of the > new restart_dma callback). NCQ retry and save/restore is AHCI-specific > and has to be done separately, similar to how we do it for SCSI already. > > Patches 1-4 set up a new (incomplete) testcase. Patches 5-13 are no-op > cleanups, or so I hope. Patches 14-23 genericize retry and make it > "just work" for all adapters for PIO. Patch 24 is another cleanup that > could probably be moved earlier in the series. > > Throwing it out since I know Kevin and mst are working on AHCI, to avoid > doing duplicate work. Patches 2 and 4 are known to be racy and > incomplete. Extremely light testing, if something breaks tells me and > I'll look at it. You forgot some CCs it seems. You're lucky that I'm reading qemu-devel today, for the first time in two weeks or so. CCing myself so I can hopefully have a look tomorrow. Kevin