From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbFYS-0002ZZ-9Z for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:06:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbFYL-00082A-4I for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:06:20 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:37834 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbFYK-00080w-Ju for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:06:13 -0400 Date: Tue, 29 Oct 2013 21:06:03 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20131029200603.GA2948@irqsave.net> References: <1380717564-11098-1-git-send-email-benoit@irqsave.net> <524ED15C.2010005@redhat.com> <20131029075929.GC2873@irqsave.net> <526FF67F.2070601@redhat.com> <526FF6D2.60004@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <526FF6D2.60004@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V9 00/11] Quorum block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Le Tuesday 29 Oct 2013 =E0 18:56:34 (+0100), Max Reitz a =E9crit : > Am 29.10.2013 18:55, schrieb Max Reitz: > > Am 29.10.2013 08:59, schrieb Beno=EEt Canet: > >> Le Friday 04 Oct 2013 =E0 16:31:56 (+0200), Max Reitz a =E9crit : > >>> On 2013-10-02 14:39, Beno=EEt Canet wrote: > >>>> It must be applied on top of "block: Add BlockDriver.bdrv_check_ex= t_snapshot." > >>>> > >>>> This patchset create a block driver implementing a quorum using to= tal qemu disk > >>>> images. Writes are mirrored on the $total files. > >>>> For the reading part the $total files are read at the same time an= d a vote is > >>>> done to determine if a qiov version is present $threshold or more = times. It then > >>>> return this majority version to the upper layers. > >>>> When i < $threshold versions of the data are returned by the lower= layer the > >>>> quorum is broken and the read return -EIO. > >>>> > >>>> The goal of this patchset is to be turned in a QEMU block filter l= iving just > >>>> above raw-*.c and below qcow2/qed when the required infrastructure= will be done. > >>>> > >>>> Main use of this feature will be people using NFS appliances which= can be > >>>> subjected to bitflip errors. > >>>> > >>>> This patchset can be used to replace blkverify and the out of tree= blkmirror. > >>>> > >>>> v9: integrate latests comments from kevin > >>>> > >>>> Beno=EEt Canet (11): > >>>> quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. > >>>> quorum: Create BDRVQuorumState and BlkDriver and do init. > >>>> quorum: Add quorum_aio_writev and its dependencies. > >>>> blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() f= rom > >>>> blkverify. > >>>> quorum: Add quorum_aio_readv. > >>>> quorum: Add quorum mechanism. > >>>> quorum: Add quorum_getlength(). > >>>> quorum: Add quorum_invalidate_cache(). > >>>> quorum: Add quorum_co_get_block_status. > >>>> quorum: Add quorum_co_flush(). > >>>> quorum: Add quorum_open() and quorum_close(). > >>>> > >>>> block/Makefile.objs | 1 + > >>>> block/blkverify.c | 108 +---- > >>>> block/quorum.c | 1035 ++++++++++++++++++++++++++++++++= +++++++++++++ > >>>> configure | 36 ++ > >>>> include/monitor/monitor.h | 2 + > >>>> include/qemu-common.h | 2 + > >>>> monitor.c | 2 + > >>>> util/iov.c | 103 +++++ > >>>> 8 files changed, 1183 insertions(+), 106 deletions(-) > >>>> create mode 100644 block/quorum.c > >>>> > >>> Could you add a qemu-iotest if possible? > >> I don't see how to specify quorum to qemu-io for bytes checking. > >> > >> Best regards > >> > >> Beno=EEt > > As of commit b543c5cd, you can pass options to the block driver throu= gh > > qemu-io -c open. The problem for quorum is that it cannot handle the > > filename option (which qemu-io will always set). I've attached a diff= to > > change this behavior (which makes the path parameter for open optiona= l > > and passes NULL to bdrv_open if it is not given). You're free to make > > use of it. ;-) > > > > If this diff is applied, you can invoke qemu-io with quorum for examp= le > > as following: > > qemu-io -c 'open -o > > file.driver=3Dquorum,file.children.0.file.filename=3D[Image > > 1],file.children.1.file.filename=3D[Image 2],file.vote_threshold=3D[x= ]' > > > > Max >=20 > Obviously forgot to attach the diff. >=20 > Max > diff --git a/qemu-io.c b/qemu-io.c > index 3b3340a..4d0e9f6 100644 > --- a/qemu-io.c > +++ b/qemu-io.c > @@ -57,8 +57,13 @@ static int openfile(char *name, int flags, int growa= ble, QDict *opts) > =20 > if (growable) { > if (bdrv_file_open(&qemuio_bs, name, opts, flags, &local_err))= { > - fprintf(stderr, "%s: can't open device %s: %s\n", progname= , name, > - error_get_pretty(local_err)); > + if (name) { > + fprintf(stderr, "%s: can't open device %s: %s\n", prog= name, > + name, error_get_pretty(local_err)); > + } else { > + fprintf(stderr, "%s: can't open device: %s\n", prognam= e, > + error_get_pretty(local_err)); > + } > error_free(local_err); > return 1; > } > @@ -66,8 +71,13 @@ static int openfile(char *name, int flags, int growa= ble, QDict *opts) > qemuio_bs =3D bdrv_new("hda"); > =20 > if (bdrv_open(qemuio_bs, name, opts, flags, NULL, &local_err) = < 0) { > - fprintf(stderr, "%s: can't open device %s: %s\n", progname= , name, > - error_get_pretty(local_err)); > + if (name) { > + fprintf(stderr, "%s: can't open device %s: %s\n", prog= name, > + name, error_get_pretty(local_err)); > + } else { > + fprintf(stderr, "%s: can't open device: %s\n", prognam= e, > + error_get_pretty(local_err)); > + } > error_free(local_err); > bdrv_unref(qemuio_bs); > qemuio_bs =3D NULL; > @@ -127,6 +137,7 @@ static int open_f(BlockDriverState *bs, int argc, c= har **argv) > int c; > QemuOpts *qopts; > QDict *opts =3D NULL; > + char *filename =3D NULL; > =20 > while ((c =3D getopt(argc, argv, "snrgo:")) !=3D EOF) { > switch (c) { > @@ -160,11 +171,13 @@ static int open_f(BlockDriverState *bs, int argc,= char **argv) > flags |=3D BDRV_O_RDWR; > } > =20 > - if (optind !=3D argc - 1) { > + if (optind =3D=3D argc - 1) { > + filename =3D argv[optind]; > + } else if (optind < argc - 1) { > return qemuio_command_usage(&open_cmd); > } > =20 > - return openfile(argv[optind], flags, growable, opts); > + return openfile(filename, flags, growable, opts); > } > =20 > static int quit_f(BlockDriverState *bs, int argc, char **argv) Thanks a lot. Best regards Beno=EEt