qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: fix 030 for faster machines
Date: Wed, 30 Oct 2013 19:45:33 +0800	[thread overview]
Message-ID: <20131030114533.GA763@T430s.nay.redhat.com> (raw)
In-Reply-To: <20131017123834.GH10774@stefanha-thinkpad.redhat.com>

On Thu, 10/17 14:38, Stefan Hajnoczi wrote:
> On Tue, Oct 15, 2013 at 10:41:51AM +0800, Fam Zheng wrote:
> > If the block job completes too fast, the test can fail. Change the
> > numbers so the qmp events are more stably captured by the script.
> > 
> > A sleep is removed for the same reason.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  tests/qemu-iotests/030 | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> Can you try using the blkdebug suspend command to pause I/O?  That way
> the test can be made reliable.

I'll give a try. The cancel_and_wait need to be replaced by cancel_resume_wait
then.

Thanks,

Fam

      reply	other threads:[~2013-10-30 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  2:41 [Qemu-devel] [PATCH] qemu-iotests: fix 030 for faster machines Fam Zheng
2013-10-16 18:45 ` Max Reitz
2013-10-17  6:28   ` Fam Zheng
2013-10-18 18:17     ` Max Reitz
2013-10-17 12:38 ` Stefan Hajnoczi
2013-10-30 11:45   ` Fam Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131030114533.GA763@T430s.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).