From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbUJW-000729-Ru for qemu-devel@nongnu.org; Wed, 30 Oct 2013 07:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbUJM-000093-DT for qemu-devel@nongnu.org; Wed, 30 Oct 2013 07:51:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbUJM-00008x-46 for qemu-devel@nongnu.org; Wed, 30 Oct 2013 07:51:44 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UBpflC008153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Oct 2013 07:51:42 -0400 Date: Wed, 30 Oct 2013 12:51:39 +0100 From: Kevin Wolf Message-ID: <20131030115139.GF2807@dhcp-200-207.str.redhat.com> References: <1383126148-1664-1-git-send-email-famz@redhat.com> <20131030111556.GC2807@dhcp-200-207.str.redhat.com> <20131030113119.GA5977@T430s.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131030113119.GA5977@T430s.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: prefill some data to test image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Am 30.10.2013 um 12:31 hat Fam Zheng geschrieben: > On Wed, 10/30 12:15, Kevin Wolf wrote: > > Am 30.10.2013 um 10:42 hat Fam Zheng geschrieben: > > > Case 030 occasionally fails because of block job compltes too fast to be > > > captured by script, and 'unexpected qmp event' of job completion causes > > > the test failure. > > > > > > Simply fill in some data to the test image to make this false alarm less > > > likely to happen. > > > > > > (For other benefits to prefill data to test image, see also commit > > > ab68cdfaa). > > > > > > Signed-off-by: Fam Zheng > > > > > > --- > > > v2: subsequent to "qemu-iotests: fix 030 for faster machines". > > > > > > Signed-off-by: Fam Zheng > > > > Did you try using blkdebug to make it deterministic instead of just > > making failure less likely? > > Yes. blkdebug relies on actual IO, but using images with no data doesn't > trigger any IO and just completes. Prefilling is the prerequisite to use that. > This alone already works very well for me, but blkdebug is good to have, too. That's actually a good point. > Suspending before starting the block job is obviously the way to do, but > resuming before cancel_and_wait is not deterministic, either, in the same way. > We'll need to add cancel_and_resume_and_wait(). > > Do you like me to respin or use a follow up patch? A follow-up patch works for me. Kevin