From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49175)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbUl4-0002W5-Le
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:20:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbUku-0002Tj-0j
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:20:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46104)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbUkt-0002TZ-PH
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:20:11 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UCKAwW007704
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 08:20:11 -0400
Date: Wed, 30 Oct 2013 13:20:04 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131030122004.GJ2807@dhcp-200-207.str.redhat.com>
References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com>
	<1382978620-16641-7-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1382978620-16641-7-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/24] ide: simplify set_inactive callbacks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben:
> Drop the unused return value and make the callback optional.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/ide/ahci.c     | 8 --------
>  hw/ide/core.c     | 5 +++--
>  hw/ide/internal.h | 2 +-
>  hw/ide/macio.c    | 1 -
>  hw/ide/pci.c      | 4 +---
>  5 files changed, 5 insertions(+), 15 deletions(-)

> @@ -1125,8 +1120,6 @@ static int ahci_async_cmd_done(IDEDMA *dma)
>          ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad);
>          qemu_bh_schedule(ad->check_bh);
>      }
> -
> -    return 0;
>  }
>  
>  static void ahci_irq_set(void *opaque, int n, int level)

This hunk should be in patch 7.

Kevin