From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbVJ0-0003EH-Sv
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:55:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbVIu-0007uf-Ur
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:55:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbVIu-0007uX-MU
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:55:20 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UCtJi0029202
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 08:55:19 -0400
Date: Wed, 30 Oct 2013 13:55:17 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131030125517.GM2807@dhcp-200-207.str.redhat.com>
References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com>
	<1382978620-16641-14-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1382978620-16641-14-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 13/24] ide: move retry constants out of
 BM_STATUS_* namespace
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/ide/core.c     | 20 ++++++++++----------
>  hw/ide/internal.h | 12 ++++++------
>  hw/ide/pci.c      | 14 +++++++-------
>  3 files changed, 23 insertions(+), 23 deletions(-)

> --- a/hw/ide/internal.h
> +++ b/hw/ide/internal.h
> @@ -485,12 +485,12 @@ struct IDEDevice {
>      uint64_t wwn;
>  };
>  
> -/* FIXME These are not status register bits */
> -#define BM_STATUS_DMA_RETRY  0x08
> -#define BM_STATUS_PIO_RETRY  0x10
> -#define BM_STATUS_RETRY_READ  0x20
> -#define BM_STATUS_RETRY_FLUSH 0x40
> -#define BM_STATUS_RETRY_TRIM 0x80
> +/* These are used for the error_status field of IDEBus */
> +#define IDE_RETRY_DMA  0x08
> +#define IDE_RETRY_PIO  0x10
> +#define IDE_RETRY_READ  0x20
> +#define IDE_RETRY_FLUSH 0x40
> +#define IDE_RETRY_TRIM 0x80

I wouldn't mind using the chance to align the numbers on the same
column (or at least removing one space where there are two)

Kevin