From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbWb7-0008Mn-Dx for qemu-devel@nongnu.org; Wed, 30 Oct 2013 10:18:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbWb1-0002GD-EV for qemu-devel@nongnu.org; Wed, 30 Oct 2013 10:18:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbWb1-0002G5-5N for qemu-devel@nongnu.org; Wed, 30 Oct 2013 10:18:07 -0400 Date: Wed, 30 Oct 2013 16:20:54 +0200 From: "Michael S. Tsirkin" Message-ID: <20131030142054.GB4853@redhat.com> References: <1383137800-2990-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383137800-2990-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/2] smbios nicer defaults for DMI type 1 (System) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de On Wed, Oct 30, 2013 at 01:56:38PM +0100, armbru@redhat.com wrote: > From: Markus Armbruster > > Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, > no version. Best SeaBIOS can do, but we can provide better defaults: > manufacturer QEMU, product & version taken from QEMUMachine desc and > name. > > This series used to be called "[PATCH v2 0/7] smbios cleanup & nicer > defaults for type 1", but its cleanup parts [0-5/7] already went in. > > Andreas didn't like "[PATCH v2 6/7] vl: Set current_machine early", > and suggested to put he machine into QEMUMachineInitArgs. PATCH 1/2 > does exactly that, replacing v2's PATCH 6/7. PATCH 2/2 is v2's PATCH > 7/7 rebased on top. > > Michael didn't like the way I suppress the nicer defaults for old > machine types via static bool smbios_type1_defaults, and thought it > would be nicer to have it in QEMUMachine or some device. I considered > this, but decided to stick to smbios_type1_defaults, because > > 1. There is no suitable device. > 2. I'd rather not extend QEMUMachine with target-specific stuff. > 3. A static bool whose default value gets flipped by some QEMUMachine > init() methods is what we commonly do in such cases, so let's stick > to that. Sorry, it seems I wasn't clear. What worries me is not how we supply the defaults, it's the fact that we expose human interface to guests. I tried to explain this better responding to the correct thread. > v3: Do it the way Andreas suggested > v2: Rebase, only last patch had conflicts > > Markus Armbruster (2): > hw: Pass QEMUMachine to its init() method > smbios: Set system manufacturer, product & version by default > > hw/i386/pc_piix.c | 9 +++++++++ > hw/i386/pc_q35.c | 7 +++++++ > hw/i386/smbios.c | 14 ++++++++++++++ > include/hw/boards.h | 7 +++++-- > include/hw/i386/smbios.h | 2 ++ > vl.c | 3 ++- > 6 files changed, 39 insertions(+), 3 deletions(-) > > -- > 1.8.1.4