From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbX1m-0001sN-Pt for qemu-devel@nongnu.org; Wed, 30 Oct 2013 10:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbX1e-0003JJ-Nu for qemu-devel@nongnu.org; Wed, 30 Oct 2013 10:45:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbX1e-0003Iu-Cs for qemu-devel@nongnu.org; Wed, 30 Oct 2013 10:45:38 -0400 Date: Wed, 30 Oct 2013 16:48:23 +0200 From: "Michael S. Tsirkin" Message-ID: <20131030144823.GA12849@redhat.com> References: <1383137800-2990-1-git-send-email-armbru@redhat.com> <1383137800-2990-3-git-send-email-armbru@redhat.com> <20131030141816.GA4853@redhat.com> <20131030142916.GU14916@otherpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131030142916.GU14916@otherpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product & version by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: armbru@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de On Wed, Oct 30, 2013 at 12:29:16PM -0200, Eduardo Habkost wrote: > On Wed, Oct 30, 2013 at 04:18:16PM +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 30, 2013 at 01:56:40PM +0100, armbru@redhat.com wrote: > > > From: Markus Armbruster > > > > > > Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, > > > no version. Best SeaBIOS can do, but we can provide better defaults: > > > manufacturer QEMU, product & version taken from QEMUMachine desc and > > > name. > > > > > > Take care to do this only for new machine types, of course. > > > > > > Signed-off-by: Markus Armbruster > > > > I feel applying this one would be a mistake. > > > > Machine desc is for human readers. > > For example, it currently says "Standard PC (Q35 + ICH9, 2009)" > > but if we add a variant with IDE compatibility mode we will likely want to > > tweak it to say "Standard PC (Q35 + ICH9/AHCI mode, 2009)" > > and add another one saying ""Standard PC (Q35 + ICH9/compat mode, > > 2009)". > > > > In other words we want the ability to tweak > > description retroactively, and exposing it to guest will > > break this ability. > > > > So we really need a new field not tied to the human description. > > > > You have a point, but if we do that one day, then we can add a new > smbios-specific field and set it for each of the existing machine-types > so they keep the same ABI. This patch doesn't make us unable to do that > in the future. We'll likely forget and just break guest ABI. So we really need a unit test for this, too. > As we are past hard freeze, I think this simple patch is better than a > more complex solution for a problem we still don't have (that can still > be implemented in 1.8). I don't see why we need to rush this into 1.7. Downstreams want their info in smbios for support, branding etc, but I don't see a burning need for this in upstream QEMU. It's kind of nice to have it say "QEMU", but we can afford to delay and do it properly for 1.8. > -- > Eduardo