Re: [Qemu-devel] [PATCH v4 2/2] vmdk: Implment bdrv_get_specific_info

[Kevin Wolf <kwolf@redhat.com>]

Am 18.10.2013 um 05:12 hat Fam Zheng geschrieben:
> Implement .bdrv_get_specific_info to return the extent information.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/vmdk.c               | 64 +++++++++++++++++++++++++++++++++++++++++++++-
>  qapi-schema.json           | 24 ++++++++++++++++-
>  tests/qemu-iotests/059     |  2 +-
>  tests/qemu-iotests/059.out |  5 ++--
>  4 files changed, 89 insertions(+), 6 deletions(-)
> 
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 5a9f278..d7fe54a 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -106,17 +106,20 @@ typedef struct VmdkExtent {
>      uint32_t l2_cache_counts[L2_CACHE_SIZE];
>  
>      int64_t cluster_sectors;
> +    char *type;
>  } VmdkExtent;
>  
>  typedef struct BDRVVmdkState {
>      CoMutex lock;
>      uint64_t desc_offset;
>      bool cid_updated;
> +    uint32_t cid;

Is it intentional that this field is never written to, i.e. we always
return cid == 0?

Kevin