From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbZYD-0003wt-Ce
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 13:27:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbZY7-00008f-BU
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 13:27:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59397)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VbZY7-00008Q-4W
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 13:27:19 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UHRIcx015886
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 13:27:18 -0400
Date: Wed, 30 Oct 2013 18:27:14 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131030172714.GP2807@dhcp-200-207.str.redhat.com>
References: <1382065965-30163-1-git-send-email-famz@redhat.com>
	<1382065965-30163-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1382065965-30163-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/2] vmdk: Implment
	bdrv_get_specific_info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 18.10.2013 um 05:12 hat Fam Zheng geschrieben:
> Implement .bdrv_get_specific_info to return the extent information.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/vmdk.c               | 64 +++++++++++++++++++++++++++++++++++++++++++++-
>  qapi-schema.json           | 24 ++++++++++++++++-
>  tests/qemu-iotests/059     |  2 +-
>  tests/qemu-iotests/059.out |  5 ++--
>  4 files changed, 89 insertions(+), 6 deletions(-)
> 
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 5a9f278..d7fe54a 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -106,17 +106,20 @@ typedef struct VmdkExtent {
>      uint32_t l2_cache_counts[L2_CACHE_SIZE];
>  
>      int64_t cluster_sectors;
> +    char *type;
>  } VmdkExtent;
>  
>  typedef struct BDRVVmdkState {
>      CoMutex lock;
>      uint64_t desc_offset;
>      bool cid_updated;
> +    uint32_t cid;

Is it intentional that this field is never written to, i.e. we always
return cid == 0?

Kevin