From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vbb9Q-0007C2-UZ for qemu-devel@nongnu.org; Wed, 30 Oct 2013 15:10:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vbb9K-0002Go-Tj for qemu-devel@nongnu.org; Wed, 30 Oct 2013 15:09:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vbb9K-0002G6-MW for qemu-devel@nongnu.org; Wed, 30 Oct 2013 15:09:50 -0400 Date: Wed, 30 Oct 2013 21:12:40 +0200 From: "Michael S. Tsirkin" Message-ID: <20131030191240.GA7330@redhat.com> References: <1383137800-2990-1-git-send-email-armbru@redhat.com> <1383137800-2990-3-git-send-email-armbru@redhat.com> <20131030141816.GA4853@redhat.com> <8761se7r1k.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8761se7r1k.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product & version by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de On Wed, Oct 30, 2013 at 03:48:55PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Oct 30, 2013 at 01:56:40PM +0100, armbru@redhat.com wrote: > >> From: Markus Armbruster > >> > >> Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, > >> no version. Best SeaBIOS can do, but we can provide better defaults: > >> manufacturer QEMU, product & version taken from QEMUMachine desc and > >> name. > >> > >> Take care to do this only for new machine types, of course. > >> > >> Signed-off-by: Markus Armbruster > > > > I feel applying this one would be a mistake. > > > > Machine desc is for human readers. > > For example, it currently says "Standard PC (Q35 + ICH9, 2009)" > > but if we add a variant with IDE compatibility mode we will likely want to > > tweak it to say "Standard PC (Q35 + ICH9/AHCI mode, 2009)" > > and add another one saying ""Standard PC (Q35 + ICH9/compat mode, > > 2009)". > > > > In other words we want the ability to tweak > > description retroactively, and exposing it to guest will > > break this ability. > > These will be new machine types, won't they? Description is there for humans, so we should be free to change it to make it more readable for old types, too. > > So we really need a new field not tied to the human description. > > The SMBIOS string is *also* for human readers. > > I can't see why we should jump through hoops *now* to separate the two. > The values are the same. I don't expect us to change them for old > machine types. But if we ever feel the need to change them in one place > but not the other, nothing will prevent us from splitting them up then. > > Pay as you go, not pay as you fear you might have to go some day.