From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VblW2-0008RJ-Ll for qemu-devel@nongnu.org; Thu, 31 Oct 2013 02:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VblVu-000235-1n for qemu-devel@nongnu.org; Thu, 31 Oct 2013 02:13:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VblVt-00022F-Pe for qemu-devel@nongnu.org; Thu, 31 Oct 2013 02:13:49 -0400 Date: Thu, 31 Oct 2013 08:16:32 +0200 From: "Michael S. Tsirkin" Message-ID: <20131031061632.GA8106@redhat.com> References: <1383137800-2990-1-git-send-email-armbru@redhat.com> <87zjpqyoll.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zjpqyoll.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de On Thu, Oct 31, 2013 at 06:51:50AM +0100, Markus Armbruster wrote: > Michael Tsirkin doesn't trust us to keep values of QEMUMachine member > product stable in the future. Use copies instead, and in a way that > makes it obvious that they're guest ABI. > > Note that we can be trusted to keep values of member name, because > that has always been ABI. > > Signed-off-by: Markus Armbruster Nice and clean. Thanks! Reviewed-by: Michael S. Tsirkin > --- > hw/i386/pc_piix.c | 3 ++- > hw/i386/pc_q35.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 417ad33..1ffa1ac 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -127,7 +127,8 @@ static void pc_init1(QEMUMachineInitArgs *args, > guest_info->has_pci_info = has_pci_info; > guest_info->isapc_ram_fw = !pci_enabled; > if (smbios_type1_defaults) { > - smbios_set_type1_defaults("QEMU", args->machine->desc, > + /* These values are guest ABI, do not change */ > + smbios_set_type1_defaults("QEMU", "Standard PC (i440FX + PIIX, 1996)", > args->machine->name); > } > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 9e3213f..0dc75c1 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -114,7 +114,8 @@ static void pc_q35_init(QEMUMachineInitArgs *args) > guest_info->has_pci_info = has_pci_info; > guest_info->isapc_ram_fw = false; > if (smbios_type1_defaults) { > - smbios_set_type1_defaults("QEMU", args->machine->desc, > + /* These values are guest ABI, do not change */ > + smbios_set_type1_defaults("QEMU", "Standard PC (Q35 + ICH9, 2009)", > args->machine->name); > } > > -- > 1.8.1.4 >