From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60248)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1Vbq6n-000233-SM
	for qemu-devel@nongnu.org; Thu, 31 Oct 2013 07:08:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1Vbq6f-0007Lm-Tc
	for qemu-devel@nongnu.org; Thu, 31 Oct 2013 07:08:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57900)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1Vbmzp-000404-TS
	for qemu-devel@nongnu.org; Thu, 31 Oct 2013 03:48:50 -0400
Date: Thu, 31 Oct 2013 09:48:44 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20131031074844.GO4651@redhat.com>
References: <1381949935-8692-1-git-send-email-mst@redhat.com>
	<20131030230618.GA5961@hawk.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131030230618.GA5961@hawk.usersys.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] import kvm-unittest in QEMU source tree
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, "Michael S. Tsirkin" <mst@redhat.com>

On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote:
> On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote:
> > This simply imports kvm-unittest git into qemu source tree.
> > 
> > We can next work on making make check run it
> > automatically.
> > 
> > Squashed 'kvm-unittest/' content from commit 2bc0e29
> > 
> > git-subtree-dir: kvm-unittest
> > git-subtree-split: 2bc0e29ee4447bebcd3b90053881f59265306adc
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > ---
> > 
> > Gleb, Paolo, any objections to this?  I really want a small guest for
> > running ACPI tests during make check, and kvm-unittest seems to fit the
> > bill.
> > 
> > Ability to test e.g. PCI with this in-tree would be very benefitial.
> >
> 
> Sorry for slow reply, I just noticed this mail now.
> 
> So far qemu is a dependency for kvm-unit-tests (both x86 and arm use it),
> but at some point that could change (if another arch doesn't want to use
> qemu). So if that happens, then it won't make much sense for the tests to
> live in qemu. Thus I'm not 100% in favor of moving them. However, if the
> consensus is to move them, then I have two comments on this patch.
> 
Do not worry, we are far from such consensus :)

> 1) There are a couple pendings patches on the kvm list that tidy up the
> kvm-unit-tests repo - removing lots of the files. That should be
> committed first to avoid importing a bunch of files right before deleting
> them.
> 
> 2) The name shouldn't change from kvm-unit-tests to kvm-unittest.
> 
> drew

--
			Gleb.