From: Stefan Hajnoczi <stefanha@gmail.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v8 16/19] block: vhdx - add .bdrv_create() support
Date: Thu, 31 Oct 2013 14:09:51 +0100 [thread overview]
Message-ID: <20131031130951.GB3605@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <f494391e0df9c284623e148927b40f3b3f99b770.1383143104.git.jcody@redhat.com>
On Wed, Oct 30, 2013 at 10:44:53AM -0400, Jeff Cody wrote:
> + if (image_size > VHDX_MAX_IMAGE_SIZE) {
> + error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB\n");
Error messages should not include '\n'.
Perhaps this can be fixed when merging the patch.
next prev parent reply other threads:[~2013-10-31 13:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 14:44 [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create() Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 01/19] block: vhdx - minor comments and typo correction Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 02/19] block: vhdx - add header update capability Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 03/19] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 04/19] block: vhdx - log support struct and defines Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 05/19] block: vhdx - break endian translation functions out Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 06/19] block: vhdx - update log guid in header, and first write tracker Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 07/19] block: vhdx code movement - move vhdx_close() above vhdx_open() Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 08/19] block: vhdx - log parsing, replay, and flush support Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 09/19] block: vhdx - add region overlap detection for image files Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 10/19] block: vhdx - add log write support Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 11/19] block: vhdx " Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 12/19] block: vhdx - remove BAT file offset bit shifting Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 13/19] block: vhdx - move more endian translations to vhdx-endian.c Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 14/19] block: vhdx - break out code operations to functions Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 15/19] block: vhdx - fix comment typos in header, fix incorrect struct fields Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 16/19] block: vhdx - add .bdrv_create() support Jeff Cody
2013-10-31 13:09 ` Stefan Hajnoczi [this message]
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 17/19] block: vhdx - update _make_test_img() to filter out vhdx options Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 18/19] block: qemu-iotests for vhdx, add write test support Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 19/19] block: vhdx qemu-iotest - log replay of data sector Jeff Cody
2013-10-31 13:10 ` [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create() Stefan Hajnoczi
2013-11-01 15:32 ` Jeff Cody
2013-11-04 11:41 ` Kevin Wolf
2013-11-01 5:04 ` [Qemu-devel] VHD suport in QEMU? Philipp Hahn
2013-11-01 9:20 ` Stefan Hajnoczi
2013-11-01 11:53 ` Jeff Cody
2013-11-06 14:34 ` [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031130951.GB3605@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).