From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38406)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vbs0i-00036X-Lt
	for qemu-devel@nongnu.org; Thu, 31 Oct 2013 09:10:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vbs0Z-0004pe-Os
	for qemu-devel@nongnu.org; Thu, 31 Oct 2013 09:10:04 -0400
Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:41191)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vbs0Z-0004nq-HH
	for qemu-devel@nongnu.org; Thu, 31 Oct 2013 09:09:55 -0400
Received: by mail-ea0-f173.google.com with SMTP id g10so1385161eak.32
	for <qemu-devel@nongnu.org>; Thu, 31 Oct 2013 06:09:54 -0700 (PDT)
Date: Thu, 31 Oct 2013 14:09:51 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131031130951.GB3605@stefanha-thinkpad.redhat.com>
References: <cover.1383143104.git.jcody@redhat.com>
	<f494391e0df9c284623e148927b40f3b3f99b770.1383143104.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f494391e0df9c284623e148927b40f3b3f99b770.1383143104.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 16/19] block: vhdx - add .bdrv_create()
 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Oct 30, 2013 at 10:44:53AM -0400, Jeff Cody wrote:
> +    if (image_size > VHDX_MAX_IMAGE_SIZE) {
> +        error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB\n");

Error messages should not include '\n'.

Perhaps this can be fixed when merging the patch.