From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtUU-0007ix-Vp for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:44:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbtUO-0000vq-F4 for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:44:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtUO-0000vl-5i for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:44:48 -0400 Date: Thu, 31 Oct 2013 16:47:29 +0200 From: "Michael S. Tsirkin" Message-ID: <20131031144729.GB9948@redhat.com> References: <1377187852-11192-1-git-send-email-pbonzini@redhat.com> <20131024023903.GD16757@G08FNSTD100614.fnst.cn.fujitsu.com> <20131031143004.GA9948@redhat.com> <52726A0B.4080805@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52726A0B.4080805@redhat.com> Subject: Re: [Qemu-devel] pvpanic plans? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, Hu Tao , qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, Paolo Bonzini , lcapitulino@redhat.com, lersek@redhat.com, afaerber@suse.de On Thu, Oct 31, 2013 at 08:32:43AM -0600, Eric Blake wrote: > On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: > > On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: > >> Hi All, > >> > >> I know it's been a long time since this thread. But qemu 1.7 is > >> releasing, do you have any consensus on this? > >> > >> Thanks. > > > > > > I think the biggest issue is the new PANICKED state. > > Guests already have simple ways to halt the CPU, > > and actually do. I think a new state was a mistake. > > So how about the following? Does it break anything? > > (Untested). > > > > Signed-off-by: Michael S. Tsirkin > > > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > > index 226e298..2055afc 100644 > > --- a/hw/misc/pvpanic.c > > +++ b/hw/misc/pvpanic.c > > @@ -51,7 +51,6 @@ static void handle_event(int event) > > > > if (event & PVPANIC_PANICKED) { > > panicked_mon_event("pause"); > > - vm_stop(RUN_STATE_GUEST_PANICKED); > > Don't you still need to halt the guest on a panic event, for management > to have a chance to choose what to do about the panic? Guest can just call hlt to do this. Most guests do this on a panic already. > I'm suspecting > this patch does break things. http://xkcd.com/1172/ > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >