From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
kwolf@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
stefanha@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] How to introduce bs->node_name ?
Date: Fri, 1 Nov 2013 10:51:39 -0400 [thread overview]
Message-ID: <20131101105139.3635bd82@redhat.com> (raw)
In-Reply-To: <52715D2F.8000109@redhat.com>
On Wed, 30 Oct 2013 13:25:35 -0600
Eric Blake <eblake@redhat.com> wrote:
> On 10/30/2013 07:49 AM, Markus Armbruster wrote:
>
> >
> > The first proposal is to add another parameter, say "id". Users can
> > then refer either to an arbitrary BDS by "id", or (for backward
> > compatibility) to the root BDS by "device". When the code sees
> > "device", it'll look up the BB, then fetch its root BDS.
> >
> > CON: Existing parameter "device" becomes compatibility cruft.
> >
> > PRO: Clean and obvious semantics (in my opinion).
>
> I like this one as well.
Does this proposal makes "device" optional for existing commands? If it
does then I'm afraid it breaks compatibility because if you don't
specify a device you'll get an error today.
Have you considered adding new commands instead?
> > I think we should review with the QMP schema first, code second.
>
> Yes, get the interface right, and then it's easier to review the code
> that implements the interface.
Agreed.
next prev parent reply other threads:[~2013-11-01 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 15:40 [Qemu-devel] How to introduce bs->node_name ? Benoît Canet
2013-10-29 1:03 ` Fam Zheng
2013-10-30 13:49 ` Markus Armbruster
2013-10-30 19:25 ` Eric Blake
2013-11-01 14:51 ` Luiz Capitulino [this message]
2013-11-01 14:59 ` Eric Blake
2013-11-01 15:12 ` Luiz Capitulino
2013-11-04 11:13 ` Kevin Wolf
2013-11-04 13:51 ` Luiz Capitulino
2013-11-04 9:31 ` Stefan Hajnoczi
2013-11-04 9:48 ` Fam Zheng
2013-11-04 11:06 ` Kevin Wolf
2013-11-04 11:33 ` Fam Zheng
2013-11-07 18:50 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101105139.3635bd82@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).