From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48104)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VcCZo-0001Dv-MQ
	for qemu-devel@nongnu.org; Fri, 01 Nov 2013 07:07:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <antonynpavlov@gmail.com>) id 1VcCZj-0000Z4-4q
	for qemu-devel@nongnu.org; Fri, 01 Nov 2013 07:07:40 -0400
Date: Fri, 1 Nov 2013 15:14:02 +0400
From: Antony Pavlov <antonynpavlov@gmail.com>
Message-Id: <20131101151402.2275a138bbcb849db3206db4@gmail.com>
In-Reply-To: <52738284.5090708@msgid.tls.msk.ru>
References: <1383021391-3152-1-git-send-email-antonynpavlov@gmail.com>
	<52738284.5090708@msgid.tls.msk.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: fix build when
 configured with no graphic support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Fri, 01 Nov 2013 14:29:24 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 29.10.2013 08:36, Antony Pavlov wrote
> > The following error occurs when building no graphic output support:
                                           ^^^^^
Can you plese fix misprint in my git commit message too.

I meant "when building with no graphic output support".

> >
> >    vl.c: In function ‘main’:
> >    vl.c:2829:19: error: variable ‘ds’ set but not used [-Werror=unused-but-set-variable]
> >         DisplayState *ds;
> >                       ^
> >    cc1: all warnings being treated as errors
> 
> Thanks, applied to the trivial-patches queue.
> 
> While at it, I also added a comment to the line being added,
> telling what this is all about:
> 
> --- a/vl.c
> +++ b/vl.c
> @@ -4269,6 +4269,7 @@ int main(int argc, char **argv, char **envp)
>       /* init local displays */
>       switch (display_type) {
>       case DT_NOGRAPHIC:
> +        (void)ds;      /* avoid warning if no display is configured */
>           break;
>   #if defined(CONFIG_CURSES)
>       case DT_CURSES:
> 
> Hopefully it is okay... ;)
> 
> /mjt


-- 
-- 
Best regards,
  Antony Pavlov