From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdDG3-0001Y2-8u for qemu-devel@nongnu.org; Mon, 04 Nov 2013 01:03:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdDFw-0007Tm-BM for qemu-devel@nongnu.org; Mon, 04 Nov 2013 01:03:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdDFw-0007TA-3Z for qemu-devel@nongnu.org; Mon, 04 Nov 2013 01:03:20 -0500 Date: Mon, 4 Nov 2013 08:06:08 +0200 From: "Michael S. Tsirkin" Message-ID: <20131104060608.GA3322@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] exec: limit system memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel.a@redhat.com, qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Jan Kiszka , Andreas =?iso-8859-1?Q?F=E4rber?= , Richard Henderson The page table logic in exec.c assumes that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS. But pci addresses are full 64 bit so if we try to render them ignoring the extra bits, we get strange effects with sections overlapping each other. To fix, simply limit the system memory size to 1 << TARGET_PHYS_ADDR_SPACE_BITS, pci addresses will be rendered within that. Signed-off-by: Michael S. Tsirkin --- exec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 030118e..c7a8df5 100644 --- a/exec.c +++ b/exec.c @@ -1801,7 +1801,12 @@ void address_space_destroy_dispatch(AddressSpace *as) static void memory_map_init(void) { system_memory = g_malloc(sizeof(*system_memory)); - memory_region_init(system_memory, NULL, "system", INT64_MAX); + + assert(TARGET_PHYS_ADDR_SPACE_BITS <= 64); + + memory_region_init(system_memory, NULL, "system", + TARGET_PHYS_ADDR_SPACE_BITS == 64 ? + UINT64_MAX : (0x1ULL << TARGET_PHYS_ADDR_SPACE_BITS)); address_space_init(&address_space_memory, system_memory, "memory"); system_io = g_malloc(sizeof(*system_io)); -- MST