From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdKHu-0008Ka-8y for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:33:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdKHo-0003XF-9B for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:33:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdKHn-0003X7-Jt for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:33:43 -0500 Date: Mon, 4 Nov 2013 08:33:39 -0500 From: Luiz Capitulino Message-ID: <20131104083339.79a190ce@redhat.com> In-Reply-To: <5276FF96.20702@linux.vnet.ibm.com> References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382321765-29052-3-git-send-email-xiawenc@linux.vnet.ibm.com> <20131101100231.5c2aa5a5@redhat.com> <5276FF96.20702@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao Xia wrote: > =E4=BA=8E 2013/11/1 22:02, Luiz Capitulino =E5=86=99=E9=81=93: > > On Mon, 21 Oct 2013 10:16:01 +0800 > > Wenchao Xia wrote: > > > >> Signed-off-by: Wenchao Xia > >> --- > >> block.c | 2 +- > >> include/block/block_int.h | 2 +- > >> include/monitor/monitor.h | 6 +++--- > >> monitor.c | 12 ++++++------ > >> stubs/mon-protocol-event.c | 2 +- > >> ui/vnc.c | 2 +- > >> 6 files changed, 13 insertions(+), 13 deletions(-) > >> > >> diff --git a/block.c b/block.c > >> index 2c15e5d..458a4f8 100644 > >> --- a/block.c > >> +++ b/block.c > >> @@ -1760,7 +1760,7 @@ void bdrv_set_dev_ops(BlockDriverState *bs, cons= t BlockDevOps *ops, > >> } > >> > >> void bdrv_emit_qmp_error_event(const BlockDriverState *bdrv, > >> - MonitorEvent ev, > >> + QEvent ev, > >> BlockErrorAction action, bool is_read) > >> { > >> QObject *data; > >> diff --git a/include/block/block_int.h b/include/block/block_int.h > >> index bcc72e2..bfdaf84 100644 > >> --- a/include/block/block_int.h > >> +++ b/include/block/block_int.h > >> @@ -337,7 +337,7 @@ AioContext *bdrv_get_aio_context(BlockDriverState = *bs); > >> int is_windows_drive(const char *filename); > >> #endif > >> void bdrv_emit_qmp_error_event(const BlockDriverState *bdrv, > >> - MonitorEvent ev, > >> + QEvent ev, > >> BlockErrorAction action, bool is_read= ); > >> > >> /** > >> diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h > >> index 10fa0e3..8b14a6f 100644 > >> --- a/include/monitor/monitor.h > >> +++ b/include/monitor/monitor.h > >> @@ -20,7 +20,7 @@ extern Monitor *default_mon; > >> #define MONITOR_CMD_ASYNC 0x0001 > >> > >> /* QMP events */ > >> -typedef enum MonitorEvent { > >> +typedef enum QEvent { > > > > Qt has a QEvent class, so QEvent is not a good name for us if we're > > considering making it public in the schema (which could become an > > external library in the distant future). > > > > I suggest calling it QMPEvent. > > >=20 > Maybe QMPEventType, since QMPEvent should be used an union? If we add the 'event' type, like: { 'event': 'BLOCK_IO_ERROR', 'data': { ... } } Then we don't need an union.