From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VdL5M-0003wB-Ko
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:25:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VdL5H-0001AA-P7
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:24:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VdL5H-00019c-HP
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:24:51 -0500
Date: Mon, 4 Nov 2013 16:26:30 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131104142630.GA29421@redhat.com>
References: <20131104104611.GA11657@redhat.com> <5277AB9E.5030903@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5277AB9E.5030903@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc
	machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Anthony Liguori <aliguori@amazon.com>, Eduardo Habkost <ehabkost@redhat.com>

On Mon, Nov 04, 2013 at 03:13:50PM +0100, Paolo Bonzini wrote:
> Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto:
> > Disable acpi build for isapc and no_kvmclock machine
> > types (used by xen), since acpi build currently expects pci.
> >=20
> > Reported-by: Andreas F=E4rber <afaerber@suse.de>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>=20
> Wait, Xen is not using pc_init_pci_no_kvmclock.  But that's not a
> problem, we can expose ACPI info via fw_cfg and then Xen hvmloader can
> decide whether to use it or not.  Right now it doesn't, maybe later on
> it should.
>=20
> If Xen is broken, we need to patch pc_xen_hvm_init, but Andreas only
> tested isapc not xenfv.  So unless someone reports otherwise, there is
> no need to exclude ACPI info from "-M xenpv".
>=20
> So my first review was wrong, but I still agree with the patch.
>=20
> Paolo

I really went by the comment
/* PC init function for pc-0.10 to pc-0.13, and reused by xenfv */
static void pc_init_pci_no_kvmclock(QEMUMachineInitArgs *args)

Clearly pc-0.13 and older should not have acpi :)

--=20
MST