From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdcvI-000397-FQ for qemu-devel@nongnu.org; Tue, 05 Nov 2013 04:27:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdcv9-0001VQ-Sc for qemu-devel@nongnu.org; Tue, 05 Nov 2013 04:27:44 -0500 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:39519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdcv9-0001Uk-Lq for qemu-devel@nongnu.org; Tue, 05 Nov 2013 04:27:35 -0500 Received: by mail-we0-f181.google.com with SMTP id t60so3229022wes.12 for ; Tue, 05 Nov 2013 01:27:34 -0800 (PST) Date: Tue, 5 Nov 2013 10:27:32 +0100 From: Stefan Hajnoczi Message-ID: <20131105092732.GB13336@stefanha-thinkpad.redhat.com> References: <1381222058-16701-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381222058-16701-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/8] Make icount thread-safe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, alex@alex.org.uk On Tue, Oct 08, 2013 at 10:47:30AM +0200, Paolo Bonzini wrote: > This series moves the icount state under the same seqlock as the "normal" > vm_clock implementation. > > It is not yet 100% thread-safe, because the CPU list should be moved > under RCU protection (due to the call to !all_cpu_threads_idle() > in qemu_clock_warp). However it is a substantial step forward, the > only uncovered case being CPU hotplug. > > Please review. Reviewed-by: Stefan Hajnoczi Not familiar with the icount code but overall the patches look good and it comes down to placing a seqlock around icount.