* [Qemu-devel] [PATCH] net: fix qemu_flush_queued_packets() in presence of a hub
@ 2013-11-05 6:54 Sergey Fedorov
2013-11-05 13:12 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Fedorov @ 2013-11-05 6:54 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, a.basov, rizzo, Sergey Fedorov, aliguori
Do not return after net_hub_flush(). Always flush callee network client
incoming queue.
Signed-off-by: Sergey Fedorov <s.fedorov@samsung.com>
---
net/net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index c330c9a..aeb479b 100644
--- a/net/net.c
+++ b/net/net.c
@@ -442,7 +442,6 @@ void qemu_flush_queued_packets(NetClientState *nc)
if (net_hub_flush(nc->peer)) {
qemu_notify_event();
}
- return;
}
if (qemu_net_queue_flush(nc->incoming_queue)) {
/* We emptied the queue successfully, signal to the IO thread to repoll
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] net: fix qemu_flush_queued_packets() in presence of a hub
2013-11-05 6:54 [Qemu-devel] [PATCH] net: fix qemu_flush_queued_packets() in presence of a hub Sergey Fedorov
@ 2013-11-05 13:12 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-11-05 13:12 UTC (permalink / raw)
To: Sergey Fedorov; +Cc: a.basov, rizzo, qemu-devel, aliguori
On Tue, Nov 05, 2013 at 10:54:29AM +0400, Sergey Fedorov wrote:
> Do not return after net_hub_flush(). Always flush callee network client
> incoming queue.
>
> Signed-off-by: Sergey Fedorov <s.fedorov@samsung.com>
> ---
> net/net.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-05 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-05 6:54 [Qemu-devel] [PATCH] net: fix qemu_flush_queued_packets() in presence of a hub Sergey Fedorov
2013-11-05 13:12 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).