From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51247)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VdiYv-0001fc-Jy
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 10:29:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VdiYn-0007Bu-2M
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 10:29:01 -0500
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:34952)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VdiYm-0007Bc-RZ
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 10:28:52 -0500
Received: by mail-wi0-f180.google.com with SMTP id ey11so2244895wid.1
	for <qemu-devel@nongnu.org>; Tue, 05 Nov 2013 07:28:52 -0800 (PST)
Date: Tue, 5 Nov 2013 16:28:49 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131105152849.GB20474@stefanha-thinkpad.redhat.com>
References: <1383141276-19230-1-git-send-email-stefanha@redhat.com>
	<1383141276-19230-3-git-send-email-stefanha@redhat.com>
	<5278DB86.2010801@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5278DB86.2010801@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add
 fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Andreas Faerber <afaerber@suse.de>

On Tue, Nov 05, 2013 at 04:50:30AM -0700, Eric Blake wrote:
> On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote:
> > qdev_device_add() leaks the created qdev upon failure.  I suspect this
> > problem crept in because qdev_free() unparents the qdev but does not
> > drop a reference - confusing name.
> 
> Is it worth renaming in a future patch?

Yep, the last patch does that.