From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vdz3c-0008Ky-KD
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 04:05:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vdz3W-0006tn-Ln
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 04:05:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60260)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vdz3W-0006tf-DL
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 04:05:42 -0500
Date: Wed, 6 Nov 2013 10:05:23 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20131106090523.GB30528@stefanha-thinkpad.redhat.com>
References: <1383664643-31552-1-git-send-email-v.maffione@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1383664643-31552-1-git-send-email-v.maffione@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4] net: Adding netmap network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: peter.maydell@linaro.org, rizzo@iet.unipi.it, mjt@tls.msk.ru, armbru@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, lcapitulino@redhat.com, rth@twiddle.net

On Tue, Nov 05, 2013 at 04:17:23PM +0100, Vincenzo Maffione wrote:
> +    err = ioctl(fd, NIOCREGIF, &req);
> +    if (err) {
> +        error_report("Unable to register %s: %s", me->ifname, strerror(err));

Did you mean strerror(errno)?

> +    me->mem = mmap(0, l, PROT_WRITE | PROT_READ, MAP_SHARED, fd, 0);
> +    if (me->mem == MAP_FAILED) {
> +        error_report("Unable to mmap netmap shared memory: %s", strerror(err));

Same here.