From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve0C3-0007YB-6d for qemu-devel@nongnu.org; Wed, 06 Nov 2013 05:18:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve0Bx-00037J-L5 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 05:18:35 -0500 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:45821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve0Bx-000375-DX for qemu-devel@nongnu.org; Wed, 06 Nov 2013 05:18:29 -0500 Received: by mail-ee0-f51.google.com with SMTP id t10so2359810eei.24 for ; Wed, 06 Nov 2013 02:18:27 -0800 (PST) Date: Wed, 6 Nov 2013 11:18:24 +0100 From: Stefan Hajnoczi Message-ID: <20131106101824.GA13052@stefanha-thinkpad.redhat.com> References: <1383669726-13701-1-git-send-email-v.maffione@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383669726-13701-1-git-send-email-v.maffione@gmail.com> Subject: Re: [Qemu-devel] [PATCH v5] net: Adding netmap network backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: peter.maydell@linaro.org, stefanha@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, lcapitulino@redhat.com, rizzo@iet.unipi.it, rth@twiddle.net On Tue, Nov 05, 2013 at 05:42:06PM +0100, Vincenzo Maffione wrote: > This patch adds support for a network backend based on netmap. > netmap is a framework for high speed packet I/O. You can use it > to build extremely fast traffic generators, monitors, software > switches or network middleboxes. Its companion software switch > VALE lets you interconnect virtual machines. > netmap and VALE are implemented as a non-intrusive kernel module, > support NICs from multiple vendors, are part of standard FreeBSD > distributions and available in source format for Linux too. > > To compile QEMU with netmap support, use the following configure > options: > ./configure [...] --enable-netmap --extra-cflags=-I/path/to/netmap/sys > where "/path/to/netmap" contains the netmap source code, available at > http://info.iet.unipi.it/~luigi/netmap/ > > The same webpage contains more information about the netmap project > (together with papers and presentations). > > Signed-off-by: Vincenzo Maffione > --- In the future, please include a changelog after the "---" line so reviewers know what to look for. I commented on v4, the strerror(error) code looks wrong, it should probably use the errno variable instead. Stefan