From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Ve0PH-0004k1-8K
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 05:32:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Ve0PA-0007iQ-2T
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 05:32:15 -0500
Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:44895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Ve0P9-0007iK-RY
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 05:32:07 -0500
Received: by mail-ea0-f177.google.com with SMTP id f15so4812744eak.36
	for <qemu-devel@nongnu.org>; Wed, 06 Nov 2013 02:32:07 -0800 (PST)
Date: Wed, 6 Nov 2013 11:32:04 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131106103204.GB24507@stefanha-thinkpad.redhat.com>
References: <1383678213-2497-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1383678213-2497-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Tue, Nov 05, 2013 at 08:03:33PM +0100, Max Reitz wrote:
> error_setg_errno() may overwrite errno; therefore, its value should be
> read before calling that function and not afterwards.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan