* [Qemu-devel] [PATCH] block: Round up total_sectors
@ 2013-11-06 11:48 Fam Zheng
2013-11-06 13:08 ` Benoît Canet
0 siblings, 1 reply; 2+ messages in thread
From: Fam Zheng @ 2013-11-06 11:48 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha
Since b94a2610, bdrv_getlength() is omitted when probing image. VMDK
monolithicFlat is broken by that because a file < 512 bytes can't be
read with its total_sectors truncated to 0. This patch round up the size
to BDRV_SECTOR_SIZE, when a image size is not sector aligned.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 58efb5b..f706634 100644
--- a/block.c
+++ b/block.c
@@ -640,7 +640,7 @@ static int refresh_total_sectors(BlockDriverState *bs, int64_t hint)
if (length < 0) {
return length;
}
- hint = length >> BDRV_SECTOR_BITS;
+ hint = DIV_ROUND_UP(length, BDRV_SECTOR_SIZE);
}
bs->total_sectors = hint;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] block: Round up total_sectors
2013-11-06 11:48 [Qemu-devel] [PATCH] block: Round up total_sectors Fam Zheng
@ 2013-11-06 13:08 ` Benoît Canet
0 siblings, 0 replies; 2+ messages in thread
From: Benoît Canet @ 2013-11-06 13:08 UTC (permalink / raw)
To: Fam Zheng; +Cc: kwolf, qemu-devel, stefanha
Le Wednesday 06 Nov 2013 à 19:48:06 (+0800), Fam Zheng a écrit :
> Since b94a2610, bdrv_getlength() is omitted when probing image. VMDK
> monolithicFlat is broken by that because a file < 512 bytes can't be
> read with its total_sectors truncated to 0. This patch round up the size
> to BDRV_SECTOR_SIZE, when a image size is not sector aligned.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 58efb5b..f706634 100644
> --- a/block.c
> +++ b/block.c
> @@ -640,7 +640,7 @@ static int refresh_total_sectors(BlockDriverState *bs, int64_t hint)
> if (length < 0) {
> return length;
> }
> - hint = length >> BDRV_SECTOR_BITS;
> + hint = DIV_ROUND_UP(length, BDRV_SECTOR_SIZE);
> }
>
> bs->total_sectors = hint;
> --
> 1.8.3.1
>
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-06 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-06 11:48 [Qemu-devel] [PATCH] block: Round up total_sectors Fam Zheng
2013-11-06 13:08 ` Benoît Canet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).