From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: marcel.a@redhat.com, qemu-devel <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected)
Date: Wed, 6 Nov 2013 20:39:12 +0200 [thread overview]
Message-ID: <20131106183912.GA16747@redhat.com> (raw)
In-Reply-To: <527A814D.5020804@redhat.com>
On Wed, Nov 06, 2013 at 06:50:05PM +0100, Paolo Bonzini wrote:
> Il 06/11/2013 18:48, Michael S. Tsirkin ha scritto:
> > This just makes the symproms go away.
>
> That's correct.
>
> > The real bug is exec ignores high address bits during page
> > lookups. It should fail on invalid address not access
> > a random page.
> > I'll send a patch.
>
> The real real bug is that all address spaces should be 2^64, which you
> said you consider too intrusive a patch.
Because this will affect performance in unpredicatable way.
We can't make such changes in 1.7 IMHO:
it would need much more than just a quick "works for me".
> I don't feel confident
> changing phys_page_find, even if it's just 2 lines.
>
> Paolo
Well it's *obviously* broken if address is outside target address
space.
Take a look at the patch first, then argue.
--
MST
next prev parent reply other threads:[~2013-11-06 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 16:22 [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected) Luiz Capitulino
2013-11-06 16:26 ` Paolo Bonzini
2013-11-06 16:29 ` Luiz Capitulino
2013-11-06 16:33 ` Michael S. Tsirkin
2013-11-06 16:30 ` Marcel Apfelbaum
2013-11-06 17:39 ` Paolo Bonzini
2013-11-06 17:48 ` Michael S. Tsirkin
2013-11-06 17:50 ` Paolo Bonzini
2013-11-06 18:39 ` Michael S. Tsirkin [this message]
2013-11-06 21:13 ` Paolo Bonzini
2013-11-06 21:36 ` Michael S. Tsirkin
2013-11-06 18:36 ` Luiz Capitulino
2013-11-06 21:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106183912.GA16747@redhat.com \
--to=mst@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).