From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve7xq-0000hV-JN for qemu-devel@nongnu.org; Wed, 06 Nov 2013 13:36:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve7xk-0000lJ-IJ for qemu-devel@nongnu.org; Wed, 06 Nov 2013 13:36:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve7xk-0000lD-AD for qemu-devel@nongnu.org; Wed, 06 Nov 2013 13:36:20 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA6IaJjr004006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Nov 2013 13:36:19 -0500 Date: Wed, 6 Nov 2013 20:39:12 +0200 From: "Michael S. Tsirkin" Message-ID: <20131106183912.GA16747@redhat.com> References: <20131106112214.14a448b6@redhat.com> <527A7EDE.3060409@redhat.com> <20131106174834.GA11767@redhat.com> <527A814D.5020804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <527A814D.5020804@redhat.com> Subject: Re: [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: marcel.a@redhat.com, qemu-devel , Luiz Capitulino On Wed, Nov 06, 2013 at 06:50:05PM +0100, Paolo Bonzini wrote: > Il 06/11/2013 18:48, Michael S. Tsirkin ha scritto: > > This just makes the symproms go away. > > That's correct. > > > The real bug is exec ignores high address bits during page > > lookups. It should fail on invalid address not access > > a random page. > > I'll send a patch. > > The real real bug is that all address spaces should be 2^64, which you > said you consider too intrusive a patch. Because this will affect performance in unpredicatable way. We can't make such changes in 1.7 IMHO: it would need much more than just a quick "works for me". > I don't feel confident > changing phys_page_find, even if it's just 2 lines. > > Paolo Well it's *obviously* broken if address is outside target address space. Take a look at the patch first, then argue. -- MST