From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeBfx-0000HH-IX for qemu-devel@nongnu.org; Wed, 06 Nov 2013 17:34:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeBfw-0004mC-CO for qemu-devel@nongnu.org; Wed, 06 Nov 2013 17:34:13 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:46061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeBfv-0004lc-VX for qemu-devel@nongnu.org; Wed, 06 Nov 2013 17:34:12 -0500 Date: Wed, 6 Nov 2013 23:34:09 +0100 From: Aurelien Jarno Message-ID: <20131106223409.GA26122@ohm.rr44.fr> References: <1383250929-10288-1-git-send-email-rth@twiddle.net> <1383250929-10288-9-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1383250929-10288-9-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 08/20] tcg-ia64: Use SUB_A3 and ADDS_A4 for subtraction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aliguori@amazon.com On Thu, Oct 31, 2013 at 01:21:57PM -0700, Richard Henderson wrote: > We can subtract from more small constants that just 0 with one insn, > and we can add the negative for most small constants. > > Signed-off-by: Richard Henderson > --- > tcg/ia64/tcg-target.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c > index be74606..d7bccd2 100644 > --- a/tcg/ia64/tcg-target.c > +++ b/tcg/ia64/tcg-target.c > @@ -1080,6 +1080,28 @@ static inline void tcg_out_add(TCGContext *s, TCGReg ret, TCGReg arg1, > } > } > > +static inline void tcg_out_sub(TCGContext *s, TCGReg ret, TCGArg arg1, > + int const_arg1, TCGArg arg2, int const_arg2) > +{ > + if (const_arg1 && arg1 == (int8_t)arg1) { > + if (const_arg2) { > + tcg_out_movi(s, TCG_TYPE_I64, ret, arg1 - arg2); > + return; > + } > + tcg_out_bundle(s, mmI, > + INSN_NOP_M, > + INSN_NOP_M, > + tcg_opc_a3(TCG_REG_P0, OPC_SUB_A3, ret, arg1, arg2)); > + } else if (const_arg2 && -arg2 == sextract64(-arg2, 0, 14)) { > + tcg_out_bundle(s, mmI, > + INSN_NOP_M, > + INSN_NOP_M, > + tcg_opc_a4(TCG_REG_P0, OPC_ADDS_A4, ret, -arg2, arg1)); > + } else { > + tcg_out_alu(s, OPC_SUB_A1, ret, arg1, const_arg1, arg2, const_arg2); > + } > +} > + > static inline void tcg_out_eqv(TCGContext *s, TCGArg ret, > TCGArg arg1, int const_arg1, > TCGArg arg2, int const_arg2) > @@ -2085,8 +2107,7 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode opc, > break; > case INDEX_op_sub_i32: > case INDEX_op_sub_i64: > - tcg_out_alu(s, OPC_SUB_A1, args[0], args[1], const_args[1], > - args[2], const_args[2]); > + tcg_out_sub(s, args[0], args[1], const_args[1], args[2], const_args[2]); > break; > > case INDEX_op_and_i32: Acked-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net