From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode
Date: Thu, 7 Nov 2013 19:52:00 +0100 [thread overview]
Message-ID: <20131107185159.GE2921@irqsave.net> (raw)
In-Reply-To: <1383850068-3903-1-git-send-email-mreitz@redhat.com>
Le Thursday 07 Nov 2013 à 19:47:48 (+0100), Max Reitz a écrit :
> If the NewImageMode is "absolute-paths" but no backing file is available
> (e.g., when mirroring a device with an unbacked image), the target image
> will not be backed either. This patch updates the documentation in
> qapi-schema.json accordingly.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Follow-up to:
> - block/drive-mirror: Check for NULL backing_hd
> ---
> qapi-schema.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 81a375b..dde8e45 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1736,7 +1736,8 @@
> # @existing: QEMU should look for an existing image file.
> #
> # @absolute-paths: QEMU should create a new image with absolute paths
> -# for the backing file.
> +# for the backing file. If there is no backing file available, the new
> +# image will not be backed either.
> #
> # Since: 1.1
> ##
> --
> 1.8.4.2
>
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
next prev parent reply other threads:[~2013-11-07 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 18:47 [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode Max Reitz
2013-11-07 18:52 ` Benoît Canet [this message]
2013-11-07 20:01 ` Eric Blake
2013-11-08 2:48 ` Wenchao Xia
2013-11-11 16:01 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107185159.GE2921@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).