From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeUgc-0000sE-7M for qemu-devel@nongnu.org; Thu, 07 Nov 2013 13:52:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeUgW-00031j-U8 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 13:52:10 -0500 Received: from nodalink.pck.nerim.net ([62.212.105.220]:42055 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeUgW-00031c-Kj for qemu-devel@nongnu.org; Thu, 07 Nov 2013 13:52:04 -0500 Date: Thu, 7 Nov 2013 19:52:00 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20131107185159.GE2921@irqsave.net> References: <1383850068-3903-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1383850068-3903-1-git-send-email-mreitz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Wenchao Xia Le Thursday 07 Nov 2013 =E0 19:47:48 (+0100), Max Reitz a =E9crit : > If the NewImageMode is "absolute-paths" but no backing file is availabl= e > (e.g., when mirroring a device with an unbacked image), the target imag= e > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly. >=20 > Signed-off-by: Max Reitz > --- > Follow-up to: > - block/drive-mirror: Check for NULL backing_hd > --- > qapi-schema.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..dde8e45 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1736,7 +1736,8 @@ > # @existing: QEMU should look for an existing image file. > # > # @absolute-paths: QEMU should create a new image with absolute paths > -# for the backing file. > +# for the backing file. If there is no backing file available, the new > +# image will not be backed either. > # > # Since: 1.1 > ## > --=20 > 1.8.4.2 >=20 >=20 Reviewed-by: Benoit Canet