From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Veimx-0006x3-KJ
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 04:55:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Veims-0000ZH-AY
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 04:55:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Veimr-0000ZC-UX
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 04:55:34 -0500
Date: Fri, 8 Nov 2013 10:55:27 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131108095527.GB2675@dhcp-200-207.str.redhat.com>
References: <1383836503-25447-1-git-send-email-benoit@irqsave.net>
	<1383836503-25447-3-git-send-email-benoit@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1383836503-25447-3-git-send-email-benoit@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] block: Allow the user to define
	"node-name" option.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>
Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com

Am 07.11.2013 um 16:01 hat Beno=EEt Canet geschrieben:
> As node-name is a separate name space as device-name we can enable it's
> definition right now: nobody will use it so no harm involved.
>=20
> Signed-off-by: Benoit Canet <benoit@irqsave.net>

As Eric already said, we need to update the QAPI schema for the new
field.

We already have an 'id' field for each BlockDriverState, which is
currently used as the device_name on the top level, and forbidden on
other devices. What is our long-term plan with this?

Should 'id' be for every node that must get a BlockBackend on top, and
'node-name' just for any node? We're mixing BDS and BB configuration
here. It may be okay to do that, especially as long as BBs don't have
more than just device_name to be configured, but we should at least be
aware that we're doing it.

Kevin