From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VenRv-0001lN-JK for qemu-devel@nongnu.org; Fri, 08 Nov 2013 09:54:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VenRp-0000x5-I8 for qemu-devel@nongnu.org; Fri, 08 Nov 2013 09:54:15 -0500 Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:59164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VenRp-0000wi-9B for qemu-devel@nongnu.org; Fri, 08 Nov 2013 09:54:09 -0500 Received: by mail-ee0-f49.google.com with SMTP id e52so1050371eek.8 for ; Fri, 08 Nov 2013 06:54:08 -0800 (PST) Date: Fri, 8 Nov 2013 15:54:05 +0100 From: Stefan Hajnoczi Message-ID: <20131108145405.GC20888@stefanha-thinkpad.redhat.com> References: <1383851429-9213-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383851429-9213-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] util/error: Save errno from clobbering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Thu, Nov 07, 2013 at 08:10:29PM +0100, Max Reitz wrote: > There may be calls to error_setg() and especially error_setg_errno() > which blindly (and until now wrongly) assume these functions not to > clobber errno (e.g., they pass errno to error_setg_errno() and return > -errno afterwards). Instead of trying to find and fix all of these > constructs, just make sure error_setg() and error_setg_errno() indeed do > not clobber errno. > > Suggested-by: Eric Blake > Signed-off-by: Max Reitz > --- > util/error.c | 6 ++++++ > 1 file changed, 6 insertions(+) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan