From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vep4V-00035R-T2 for qemu-devel@nongnu.org; Fri, 08 Nov 2013 11:38:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vep4P-0002xl-BG for qemu-devel@nongnu.org; Fri, 08 Nov 2013 11:38:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vep4P-0002xP-2a for qemu-devel@nongnu.org; Fri, 08 Nov 2013 11:38:05 -0500 Date: Fri, 8 Nov 2013 17:37:44 +0100 From: Igor Mammedov Message-ID: <20131108173744.1ab160d3@thinkpad> In-Reply-To: <1383863039-18875-1-git-send-email-lersek@redhat.com> References: <1383859470.2527.64.camel@localhost.localdomain> <1383863039-18875-1-git-send-email-lersek@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, marcel.a@redhat.com, jan.kiszka@siemens.com, edk2-devel@lists.sourceforge.net, qemu-devel@nongnu.org, mst@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com, jljusten@gmail.com, afaerber@suse.de, rth@twiddle.net On Thu, 7 Nov 2013 23:23:57 +0100 Laszlo Ersek wrote: > On 11/07/13 22:24, Marcel Apfelbaum wrote: > > > Why pci-hole and system.flash collide? IMHO we should not play with > > priorities here, better solve the collision. > > What about this "beautiful" series? It produces Laszlo, there is patch that removes PCI-hole aliases at all mapping PCI address space with -1 priority in system address space. so all access flash region range will go to it sice it's priority 0 > > memory > 0000000000000000-000fffffffffffff (prio 0, RW): system > [...] > 0000000060000000-00000000ffdfffff (prio 0, RW): alias pci-hole @pci > 0000000060000000-00000000ffdfffff > [...] > 00000000ffe00000-00000000ffffffff (prio 0, R-): system.flash > > and I can run OVMF with it. It also stays within i386/pc. > > Re 2/2, note that "below_4g_mem_size" never exceeds 0xe0000000 in > pc_init1(), so the subtraction is safe. > > Thanks > Laszlo > > Laszlo Ersek (2): > i386/pc: propagate flash size from pc_system_flash_init() to > pc_init1() > i386/pc_piix: the pci-hole should end where the system flash starts > > include/hw/i386/pc.h | 6 ++++-- > hw/i386/pc.c | 5 +++-- > hw/i386/pc_piix.c | 5 +++-- > hw/i386/pc_q35.c | 3 ++- > hw/i386/pc_sysfw.c | 10 +++++++--- > 5 files changed, 19 insertions(+), 10 deletions(-) > > -- > 1.8.3.1 > > -- Regards, Igor