From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap
Date: Mon, 11 Nov 2013 11:34:32 +0100 [thread overview]
Message-ID: <20131111103432.GJ28264@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1383557410-18062-1-git-send-email-famz@redhat.com>
On Mon, Nov 04, 2013 at 05:30:10PM +0800, Fam Zheng wrote:
> @@ -2785,9 +2792,7 @@ static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs,
> ret = bdrv_co_flush(bs);
> }
>
> - if (bs->dirty_bitmap) {
> bdrv_set_dirty(bs, sector_num, nb_sectors);
> - }
Forgot to reduce indentation?
next prev parent reply other threads:[~2013-11-11 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 9:30 [Qemu-devel] [PATCH v2] block: per caller dirty bitmap Fam Zheng
2013-11-04 10:37 ` Paolo Bonzini
2013-11-04 10:47 ` Fam Zheng
2013-11-04 10:55 ` Paolo Bonzini
2013-11-11 10:31 ` Stefan Hajnoczi
2013-11-04 14:38 ` Benoît Canet
2013-11-05 3:12 ` Fam Zheng
2013-11-11 10:34 ` Stefan Hajnoczi [this message]
2013-11-11 10:35 ` Stefan Hajnoczi
2013-11-12 10:46 ` Kevin Wolf
2013-11-12 13:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111103432.GJ28264@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).