From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51397)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VfopQ-00052w-Af
	for qemu-devel@nongnu.org; Mon, 11 Nov 2013 05:34:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VfopH-0007Du-Ua
	for qemu-devel@nongnu.org; Mon, 11 Nov 2013 05:34:44 -0500
Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:38765)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VfopH-0007Dm-OH
	for qemu-devel@nongnu.org; Mon, 11 Nov 2013 05:34:35 -0500
Received: by mail-ea0-f170.google.com with SMTP id q10so2112861eaj.29
	for <qemu-devel@nongnu.org>; Mon, 11 Nov 2013 02:34:34 -0800 (PST)
Date: Mon, 11 Nov 2013 11:34:32 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131111103432.GJ28264@stefanha-thinkpad.redhat.com>
References: <1383557410-18062-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1383557410-18062-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Nov 04, 2013 at 05:30:10PM +0800, Fam Zheng wrote:
> @@ -2785,9 +2792,7 @@ static int coroutine_fn bdrv_co_do_writev(BlockDriverState *bs,
>          ret = bdrv_co_flush(bs);
>      }
>  
> -    if (bs->dirty_bitmap) {
>          bdrv_set_dirty(bs, sector_num, nb_sectors);
> -    }

Forgot to reduce indentation?