From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Vgaf8-000124-UY
	for qemu-devel@nongnu.org; Wed, 13 Nov 2013 08:39:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Vgaf0-0002g3-2a
	for qemu-devel@nongnu.org; Wed, 13 Nov 2013 08:39:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Vgaez-0002fp-Ph
	for qemu-devel@nongnu.org; Wed, 13 Nov 2013 08:39:10 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rADDd8VN019895
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Nov 2013 08:39:08 -0500
Date: Wed, 13 Nov 2013 14:39:09 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131113133909.GD2633@dhcp-200-207.str.redhat.com>
References: <1384345671-14866-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1384345671-14866-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in
	drive_add
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 13.11.2013 um 13:27 hat Fam Zheng geschrieben:
> This will allow running iotests on tmpfs, which is much faster, so we
> can run more tests.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/iotests.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index fb10ff4..c29314a 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -96,7 +96,7 @@ class VM(object):
>          '''Add a virtio-blk drive to the VM'''
>          options = ['if=virtio',
>                     'format=%s' % imgfmt,
> -                   'cache=none',
> +                   'cache=writeback',
>                     'file=%s' % path,
>                     'id=drive%d' % self._num_drives]
>          if opts:

Well, in fact any fixed value is wrong here. By default, qemu-iotests is
supposed to use cache=writethrough for everything, and ./check -nocache
should make it cache=none. I think what we really want is a ./check
option that allows specifying any cache option, and then we should make
the scripts honour that option.

Kevin